MSTEST0052: Avoid passing an explicit 'DynamicDataSourceType' and use the default auto detect behavior

Cause

A DynamicDataAttribute explicitly specifies Property or Method instead of using the default AutoDetect.

Rule description

Starting with MSTest 3.8, DynamicDataSourceType.AutoDetect is the default value for the DynamicDataSourceType parameter in the DynamicDataAttribute constructor. This enhancement automatically detects whether the data source is a property, method, or field, eliminating the need to explicitly specify the source type. Using AutoDetect makes the code more maintainable and reduces verbosity.

How to fix violations

Remove the explicit DynamicDataSourceType parameter from the DynamicData attribute and let the framework auto-detect the source type.

For example, change this:

public static IEnumerable<object[]> TestData { get; } = new[]
{
    new object[] { 1, 2, 3 },
    new object[] { 4, 5, 9 }
};

[TestMethod]
[DynamicData(nameof(TestData), DynamicDataSourceType.Property)]
public void TestMethod(int a, int b, int expected)
{
    Assert.AreEqual(expected, a + b);
}

To this:

public static IEnumerable<object[]> TestData { get; } = new[]
{
    new object[] { 1, 2, 3 },
    new object[] { 4, 5, 9 }
};

[TestMethod]
[DynamicData(nameof(TestData))]
public void TestMethod(int a, int b, int expected)
{
    Assert.AreEqual(expected, a + b);
}

When to suppress warnings

Don't suppress warnings from this rule. Following the analyzer suggestion leads to less noise in the test code.